foxnewsnetwork / rubyopenvn

Ruby-based implementation of FFOpenVN as ported over from nodejs
1 stars 0 forks source link

ajax but update the url #10

Open foxnewsnetwork opened 12 years ago

foxnewsnetwork commented 12 years ago

One of the great things about ajax is that you can render only partial views and thus provide for better UX. But get-based ajax would be a lot nicer if they can also update the url. This is, in particular, important when it comes to the page tabs I have implemented on stories/show and stories/edit. Check them out and see if you can't get the ajax requests to also update the url.

trevor-umeda commented 12 years ago

I need some clarification on this. I'm looking at stories/show and i see the tabs i.e. splash, reviews etc.

Do you want the url to read like stories/1/splash and stories/1/reviews and so on?

foxnewsnetwork commented 12 years ago

Short answer: yes.

Long answer: yes, but stories/1?usertab=splash is also okay.

trevor-umeda commented 12 years ago

Alright it's done for stories show. It should work fine though I had to do a little nasty thing to make it change the url for the splash page as that loads first on stories show.

Gonna post an issue to expand on this url idea further.

Close this issue if it works to your satisfaction

foxnewsnetwork commented 12 years ago

looks good so far, but I will do more checks / testing before I close this issue