search

foxnewsnetwork / rubyopenvn

Ruby-based implementation of FFOpenVN as ported over from nodejs
1 stars 0 forks source link

Story show id should be title #13

Open trevor-umeda opened 12 years ago

trevor-umeda commented 12 years ago

To expand on the idea of github like format. For story show, instead of the url being stories/1 it could be stories/Life_Of_Thomas if Life_Of_Thomas was the name of the story.

To do it would be simple enough I believe and since it's a minor enhancement I'll try to get it done sometime soon. If this is a dumb idea close this issue.

trevor-umeda commented 12 years ago

Alright it works. Lemme know if you want it pushed but because I added the slug attribute to stories, you'll have to delete the stories you have created because they wont' have slugs (Slugs are made on Story Creation).

If you give the okay I'll push it up.

foxnewsnetwork commented 12 years ago

This is a good idea; push it up and I will reseed my db as necessary! GW

foxnewsnetwork commented 12 years ago

Just doing some live testing when I came across various nil class issues. This is caused by the following line in the controllers:

story = find_by_id( params[:id] )

and can be readily solved by replacing with:

story = find_by_slug(params[:id]) story || = find_by_id(params[:id])

I've probably got most of them by now, but in case there are any left, please replace them as necessary