search

foxriver76 / ioBroker-Visu-App

This is the issue tracker for the "ioBroker Visu" Android and iOS App
7 stars 0 forks source link

[FEATURE] Open target `_blank` links in browser #15

Closed foxriver76 closed 1 year ago

foxriver76 commented 1 year ago

Is there an existing feature request for this?

Feature description

At least on iOS this is not done by default. The problem is, we cannot detect if the navigation change comes from such links or not - need to wait until https://github.com/react-native-webview/react-native-webview/pull/2640 is implemented

Anything else?

No response

RK62 commented 1 year ago

Why not using the simple solution of the old app and implementing a switch for browser selection? I don't want to decide it per window, external links should always be opened in Safari for compatibility reasons.

foxriver76 commented 1 year ago

The problem is, that we can currently not detect for sure, if it is an external link.The only heuristic I can think of, is to check if the base url is not contained.

RK62 commented 1 year ago

The approach "base url" sounds very pragmatic. This can be further improved at a later time.

foxriver76 commented 1 year ago

Part of 1.0.21

RK62 commented 1 year ago

Thanks, works fine!

RK62 commented 1 year ago

In Version 1.0.28 external links again are opened in the app and not in Safari.

foxriver76 commented 1 year ago

Ah while migrating to a new version of expo, it downgraded the webview package, will be fixed in next version - sorry

RK62 commented 1 year ago

No problem, thanks for your excellent work!

foxriver76 commented 1 year ago

hopefully works again

RK62 commented 1 year ago

Works fine as before! Thank you very much!