search

foxriver76 / ioBroker.denon

Denon AVR adapter for ioBroker
MIT License
19 stars 9 forks source link

Please fix issues reported by adapter checker #360

Open mcm1957 opened 1 month ago

mcm1957 commented 1 month ago

❗ [E518] "@alcalzone/release-script" (>=3.0.0) is used, but ".releaseconfig.json" not found. Please create. 👀 [W105] Missing suggested translation into ru,pt,nl,fr,it,es,pl,uk,zh-cn of "common.titleLang" in io-package.json. 👀 [W109] Missing suggested translation into uk of "common.desc" in io-package.json. 👀 [W162] js-controller 5.0.0 listed as dependency but 5.0.19 is recommended. Please consider updating dependency at io-package.json. 👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI". 👀 [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json. 👀 [W521] "gulp" found at devDependencies at package.json but no "gulpfile.js" found. Is this dependency really required? 👀 [W522] Please consider migrating to admin 5 UI (jsonConfig).

foxriver76 commented 1 month ago

Release Script can also be used with cli args

mcm1957 commented 1 month ago

Thats really atypically. Yes it can be used this way but even then the config file would not do any harm and serve as a fallback. If commandline arguments are missing, the script will otherwise do an partly change only.

foxriver76 commented 1 month ago

The args are configured hard in the npm scripts in pack json and anyway the release script here is just executed from the CI. I don’t see it as an error to not have a config tbh.

https://github.com/foxriver76/ioBroker.denon/blob/812abd16ee7aadba6107802a8503fab3450b3dc2/package.json#L64

mcm1957 commented 1 month ago

Ok, I see. I confirm that this will work and is save - although ruther unusual.

I'll check whether its possible to check this exceptional config at checker. Until check is adapted you will get the error message as in 99% of all cases the missing file is an error. Please filter it out manually :-). Adding the file would still be a possibility to remove the error until the check is extended.