Clean up GUI

[thanasipantazides]

Stuff to add

Currently, the GUI looks like this:

And it does very little. Need to add functionality to existing UI elements, plus more elements.

• [ ] #10
• [ ] #9
• [x] "Strips/Pixels" button (DetectorPanel.modalImageButton) should open a modal window to table-style editor, where individual strips or pixels can be masked/disabled, thresholds adjusted, etc.
• [x] "Parameters" button (DetectorPanel.modalParamsButton) should open a modal window where detector/ASIC parameters can be edited.
• [x] "Focus Plot" button (DetectorPanel.modalPlotButton) should open a modal window focusing on just that plot (see application.GSEFocus class).

[thanasipantazides]

Also:

• [x] Use QtWidgets.QFrame to group one detector's buttons and plot. I think you need to add all the widgets to the frame, then can add the frame to the layout?

[thanasipantazides]

Ok, now it can look like this (on a laptop screen, at night):

The Focus detector yields a popup window like this:

but the tabs besides Plot show nothing. This is achieved by reparenting DetectorPanel to a new parentless widget GSEPopout which contains a QTabWidget.

Options for moving forward:

There are a couple ways to move forward with populating the table view (for strips or pixels), parameters view (for general detector parameter setting), and other detector data views:

1. Don't reparent DetectorPanel to GSEPopout, just reparent a composite widget for its plot (possibly its QGroupBox). Then, add more composite widgets to DetectorPanel—one for each tab view in GSEPopout. Call .hide() on them on __init__() and .show() them when the popout is created. This way, all detector-specific data and interfaces are under DetectorPanel.
2. Create standalone DetectorPlotView (e.g.), DetectorStripTableView, etc classes for each tab and instantiate them as needed from GSEPopout or DetectorGridView. They can all inherit from a common DetectorBackend which persists across the application and handles stuff like the FormatterUDPInterface and disk I/O for plotting. This may be a more layered architecture (and more inline with MVC) but a big refactor (including of Kris's code).

These really amount to the same thing (QWidgets inside an aggregate QWidget), so I'd rather bite the bullet and refactor everything under a well-designed parent (option (2)).

To do:

To implement (2), do:

• [x] Rename DetectorPanel to something more informative, like DetectorPlotView.
• [ ] Pass DetectorPlotView constructor some structure of detector parameters (to hold parser, normal ranges for HK values, etc). Use placeholder object for now. Should just become attribute of DetectorPlotView.
• [x] Pass DetectorPlotView constructor some FormatterUDPInterface-like object.
  • [ ] (auxiliary, maybe make separate issue): Add ListenerLogger log file reading to FormatterUDPInterface. If done, rename FormatterInterface. Since all DetectorPlotViews should hold a reference to the same FormatterUDPInterface, there should not be 7 separate file read actions going on at once.
  • [ ] In subclasses of DetectorPlotView, move file I/O to use FormatterInterface.
• [ ] Add DetectorStripView as an aggregation of a QTableWidget and a couple QPushButtons which pull and push data to and from FOXSI via FormatterUDPInterface.
  • [x] Should hold reference (passed on __init__()) to FormatterUDPInterface.
  • [x] Should be hidden in popout view.
  • [ ] Later, add DetectorPixelView for CMOS and Timepix.
• [ ] Add DetectorParametersView as an aggregation of a QFormLayout and some QPushButtons which pull and push data to and from FOXSI via FormatterUDPInterface.
  • [x] Should hold reference (passed on __init__()) to FormatterUDPInterface.
  • [x] Should be hidden in popout view.
• [ ] Add DetectorCommandView as a filtered/reduced GlobalCommandPanel.
  • [x] Should hold reference (passed on __init__()) to FormatterUDPInterface.
  • [x] Should be hidden in popout view.
• [x] Add DetectorContainer or something to hold DetectorPlotView, DetectorStripView, DetectorParametersView, and DetectorCommandView.
  • [x] Should have attribute list for widgets to show in popout.
  • [x] Should have attribute list for widgets to show in main grid view.
  • [x] Should have .handlePopout() and .handlePopin() methods.

[thanasipantazides]

And, add superclass of all Detector...Views that include self.name, self.label, other expected attributes for displaying.