First and foremost, thank you so much for opening a PR for this repository. Any contribution is greatly appreciated.
[!Note]
To make this process as easy as possible to follow when looking over and discussing the PR, please respond to each field below.
The fields below should inform the reader of the purpose(s) for the PR without having to infer things from the code itself.
What is reason for this PR
[ ] Bug fix
[ ] New feature
[x] Behavioural change
[x] Other
Cleaning code and a breaking change
Describe why the PR is needed
For example, what problem is being tackled? What new behaviour is needed?
A lot of values specific to each system was hard-coded into the GSE. These values should really be taken from one source and that should be foxsi4-commands.
Please provide a description of the changes/additions being made to the package
Although the changes in the code can be clear, try to describe the conceptial changes being made to the repository.
Just adding in functions that look up the JSON table from the foxsi4-commands package for the values needed in the GSE. This mainly only includes the frame sizes for each system.
Are there any dangers in this change
In a perfect, flawless, ideal, faultless world all changes would be without danger and never have any knock-on effects; however, sadly, our world is not perfect, flawless, ideal, or faultless.😔
The PR could be introducing breaking changes which may seem to be resolved by the time of this PR. However, here is a good space to lay out what those breaking changes were and how they were resolved, as well as to highlight any change for future alterations/tests/features.
This links the repo to foxsi4-commands directly. This means that, unlike previous versions, both packages need to be installed rater than just the GSE.
A PR for FOXSI-4's GSE 🦊
First and foremost, thank you so much for opening a PR for this repository. Any contribution is greatly appreciated.
What is reason for this PR
Describe why the PR is needed
For example, what problem is being tackled? What new behaviour is needed?
A lot of values specific to each system was hard-coded into the GSE. These values should really be taken from one source and that should be foxsi4-commands.
Please provide a description of the changes/additions being made to the package
Although the changes in the code can be clear, try to describe the conceptial changes being made to the repository.
Just adding in functions that look up the JSON table from the foxsi4-commands package for the values needed in the GSE. This mainly only includes the frame sizes for each system.
Are there any dangers in this change
In a perfect, flawless, ideal, faultless world all changes would be without danger and never have any knock-on effects; however, sadly, our world is not perfect, flawless, ideal, or faultless. 😔
The PR could be introducing breaking changes which may seem to be resolved by the time of this PR. However, here is a good space to lay out what those breaking changes were and how they were resolved, as well as to highlight any change for future alterations/tests/features.
This links the repo to foxsi4-commands directly. This means that, unlike previous versions, both packages need to be installed rater than just the GSE.