First and foremost, thank you so much for opening a PR for this repository. Any contribution is greatly appreciated.
[!Note]
To make this process as easy as possible to follow when looking over and discussing the PR, please respond to each field below.
The fields below should inform the reader of the purpose(s) for the PR without having to infer things from the code itself.
What is reason for this PR
[x] Bug fix
[ ] New feature
[x] Behavioural change
[ ] Other
...
Describe why the PR is needed
For example, what problem is being tackled? What new behaviour is needed?
CdTe needed a new parser to calculate livetime.
Please provide a description of the changes/additions being made to the package
Although the changes in the code can be clear, try to describe the conceptial changes being made to the repository.
New CdTe parser is added.
Are there any dangers in this change
In a perfect, flawless, ideal, faultless world all changes would be without danger and never have any knock-on effects; however, sadly, our world is not perfect, flawless, ideal, or faultless.😔
The PR could be introducing breaking changes which may seem to be resolved by the time of this PR. However, here is a good space to lay out what those breaking changes were and how they were resolved, as well as to highlight any change for future alterations/tests/features.
None as of yet but still unsure if the livetime values are treated correctly. Additionally, made use of flush_events() to speed up matplotlib plotting but this means closing widgets with widgets as attributes can be tricky (they just want to keep going).
A PR for FOXSI-4's GSE 🦊
First and foremost, thank you so much for opening a PR for this repository. Any contribution is greatly appreciated.
What is reason for this PR
Describe why the PR is needed
For example, what problem is being tackled? What new behaviour is needed?
CdTe needed a new parser to calculate livetime.
Please provide a description of the changes/additions being made to the package
Although the changes in the code can be clear, try to describe the conceptial changes being made to the repository.
New CdTe parser is added.
Are there any dangers in this change
In a perfect, flawless, ideal, faultless world all changes would be without danger and never have any knock-on effects; however, sadly, our world is not perfect, flawless, ideal, or faultless. 😔
The PR could be introducing breaking changes which may seem to be resolved by the time of this PR. However, here is a good space to lay out what those breaking changes were and how they were resolved, as well as to highlight any change for future alterations/tests/features.
None as of yet but still unsure if the livetime values are treated correctly. Additionally, made use of
flush_events()to speed upmatplotlibplotting but this means closing widgets with widgets as attributes can be tricky (they just want to keep going).