First and foremost, thank you so much for opening a PR for this repository. Any contribution is greatly appreciated.
You're very welcome!
[!Note]
To make this process as easy as possible to follow when looking over and discussing the PR, please respond to each field below.
The fields below should inform the reader of the purpose(s) for the PR without having to infer things from the code itself.
What is reason for this PR
[ ] Bug fix
[ ] New feature
[ ] Behavioural change
[x] Other
Moving modules that can be used elsewhere out of the repository. Moving the parsers, collections, and data modules to telemetry_tools.
Describe why the PR is needed
For example, what problem is being tackled? What new behaviour is needed?
The code can be used in a lot of places and it isn't great to have to take all the GUI stuff with it.
Please provide a description of the changes/additions being made to the package
Although the changes in the code can be clear, try to describe the conceptial changes being made to the repository.
Just moved stuff about. Made the desired modules into one submodule.
Are there any dangers in this change
In a perfect, flawless, ideal, faultless world all changes would be without danger and never have any knock-on effects; however, sadly, our world is not perfect, flawless, ideal, or faultless.😔
The PR could be introducing breaking changes which may seem to be resolved by the time of this PR. However, here is a good space to lay out what those breaking changes were and how they were resolved, as well as to highlight any change for future alterations/tests/features.
A PR for FOXSI-4's GSE 🦊
First and foremost, thank you so much for opening a PR for this repository. Any contribution is greatly appreciated.
You're very welcome!
What is reason for this PR
parsers,collections, anddatamodules totelemetry_tools.Describe why the PR is needed
For example, what problem is being tackled? What new behaviour is needed?
The code can be used in a lot of places and it isn't great to have to take all the GUI stuff with it.
Please provide a description of the changes/additions being made to the package
Although the changes in the code can be clear, try to describe the conceptial changes being made to the repository.
Just moved stuff about. Made the desired modules into one submodule.
Are there any dangers in this change
In a perfect, flawless, ideal, faultless world all changes would be without danger and never have any knock-on effects; however, sadly, our world is not perfect, flawless, ideal, or faultless. 😔
The PR could be introducing breaking changes which may seem to be resolved by the time of this PR. However, here is a good space to lay out what those breaking changes were and how they were resolved, as well as to highlight any change for future alterations/tests/features.
Loads, (not really) but let's go for it! :o