contain variable and function declarations in the global scope—they are not part of any class. It would be safer to wrap all of these in a namespace. Then, instead of referring to the SPACEWIRE_ADDRESS_LENGTH variable, we could do parameters::SPACEWIRE_ADDRESS_LENGTH or something. Same thing for the functions in Utilities.h.
So the todo items for this task:
[x] Come up with ways to clump the parameters and utilities that make sense (Ethernet stuff, SpaceWire stuff, etc could be grouped)
[x] Put each clump in its own namespace
[x] Refactor the rest of the code to use the namespace::name instead of just the bare variable/function name.
yixianz
commented
1 year ago
The following files
contain variable and function declarations in the global scope—they are not part of any class. It would be safer to wrap all of these in a namespace. Then, instead of referring to the
SPACEWIRE_ADDRESS_LENGTHvariable, we could doparameters::SPACEWIRE_ADDRESS_LENGTHor something. Same thing for the functions inUtilities.h.So the todo items for this task:
From Thanasi's Google Doc