search

foxsi / foxsi-science

Analysis tools to reduce and analyze data from the FOXSI sounding rocket flights
7 stars 13 forks source link

Updates to include FOXSI-3 #74

Closed somusset closed 4 years ago

somusset commented 5 years ago

The option for FOXSI-3 was added to a few files, as well as a correction to calculate altitude in level0 to level1.

jtvievering commented 5 years ago

For line 60 in foxsi_level0_to_level1.pro, I wonder if the default filename should be for the FOXSI-2 level 0 data since the default year is 2014?

jtvievering commented 5 years ago

In wsmr_data_to_hskp_level0.pro, lines 244-258 use appear to use information specific to the 2012 flight; add the capability to process data from 2014 and 2018.

somusset commented 4 years ago

The altitude is extracted in foxsi_level0_to_level1.pro Therefore, this if statement could be removed here, but just in case it is used in someone's code, I left it. We could also decide that we want to have altitude data in the level 0 files, which is not the case here, except for FOXSI-1 because of these lines... I added a comment in the code. We could merge this pull request and make an issue to discuss this further without delaying the merging of the pull request, what do you think?

jtvievering commented 4 years ago

That makes sense, and I don't feel strongly about having the altitude information in the level 0 data. The comments you added help to clarify the purpose of the code, and I think this pull request is ready to be merged!