search

foxsi / foxsi-smex

Tools for scientists to investigate the capabilities of FOXSI
MIT License
2 stars 8 forks source link

Updating FOXSI effective area response #43

Closed aringlis closed 8 years ago

aringlis commented 8 years ago

Updating the FOXSI response function - configuration is 14m, 2 modules, 20 shells. Addresses #38

@ehsteve @LinErinG - is effective_area_per_shell.csv still used in the code? shell_parameters.csv also exists and seems to be called by the solitary function foxsi_get_optics_properties.pro. I will update this with the new shell parameters, but do we want to retain this?

This addresses issue number #43.

ehsteve commented 8 years ago

@aringlis ignore the shell_parameters.csv file for now. The purpose of that was to allow people to play with the different shells but we don't need to do that right now.

ehsteve commented 8 years ago

I would also remove any mention of different configurations as we only have one. No need to needlessly confuse people.

aringlis commented 8 years ago

@ehsteve ok will do - I had only kept the configuration parameter for backwards compatibility.

LinErinG commented 8 years ago

Test-ran this and everything looked fine, so I'll merge it.