search

foxsi / foxsi-smex

Tools for scientists to investigate the capabilities of FOXSI
MIT License
2 stars 8 forks source link

Adding warnings for high rates at detector #45

Closed LinErinG closed 8 years ago

LinErinG commented 8 years ago

I added a warning if high rates are detected at the detector on either a per-pixel or per-detector basis in foxsi_get_output_image_cube.pro. Note that the default source (which is really bright!!) is high enough to trigger this warning with any attenuator state. We should maybe temper that down a bit. But I've left the default source bright for now for you to play around and test this. Let me know what you think, and feel free to suggest further edits. (Side note: we really do need to revisit that effective area interpolation, as it's unwieldy. Though it seems to be working fine, so if it ain't broke...)

LinErinG commented 8 years ago

@ehsteve @ayshih @aringlis A ping for someone to try running this and see how well you like it. Suggestions welcome!

LinErinG commented 8 years ago

Another ping for someone to try running this. One concern is that I put in a "per-detector" rate, but so far I have been simulating the entire effective area as if it were on one telescope and one detector. That's not right, but may not be worth changing in the near term. For the rates it's a factor of two.

ayshih commented 8 years ago

I think it would be greatly useful if the warning message also included the information of which threshold was exceeded, what that threshold is currently set to, and the actual over-threshold value. Right now, the binary nature of the warning message doesn't provide even a vague sense of how bad the current image cube might be, nor whether increasing the attenuator state has appreciably improved matters in the case where the warning is still triggered.

LinErinG commented 8 years ago

Agreed these would be good edits. I'll work on them and will update when I've got that done.

ayshih commented 8 years ago

For tracking purposes, this PR is in response to #39