foxssake / netfox

Addons for building multiplayer games with Godot
https://foxssake.github.io/netfox/
MIT License
389 stars 16 forks source link

Fix nested properties not being applied #224

Closed jonstvns closed 5 months ago

jonstvns commented 5 months ago

When using the netfox synchronizers, nested properties were being read and serialized correctly, but on the receiving end, the data would silently fail to be applied to the synced node because the function set_value() in property-entry.gd was using node.set() instead of node.set_indexed()

elementbound commented 5 months ago

Nice catch, thanks @jonstvns! Would you mind setting the addon versions to 1.6.1 please? If you're on Linux / WSL, you can run sh/version.sh bump patch from the repo root.

elementbound commented 5 months ago

Nvm, realized I can also push changes :smile: Thanks again @jonstvns and welcome to the club of netfox contributors :smile:

jonstvns commented 5 months ago

Ahh, sorry, I was traveling and forgot you asked me to bump the version number.

thanks for merging, @elementbound