State Machine example is broken

[krazyjakee]

Bug Description

Clients do not always receive state change notifications from other clients when using RewindableStateMachine. Specifically, state transitions like entering IDLE are sometimes not synchronized across all clients, leading to inconsistent animation states.

Steps to reproduce

1. Run State Machine example
2. Move around and jump on multiple clients

Expected behavior

1. All connected clients receive consistent state change messages from other players.
2. State transitions, such as moving to IDLE, should be applied across all clients.

Observed behavior

1. State change messages are not consistently received by all clients.
2. Only the host and the client that triggers the state change receive the update, while other clients do not.

Versions

• Godot version: 4.1
• netfox version: Main branch (not officially released)

Notes

• Testing on a dedicated server setup may produce different results.
• The multiplayer-state-machine demo did not function as expected when hitting host/join.
• The current setup uses the latest Netfox version cloned from the main branch, not an official release.
• The issue occurs regardless of amount of latency

[TheYellowArchitect]

Uploading video confirmation

https://github.com/user-attachments/assets/b9bbb894-a9f3-458f-8886-308a3dd16cdf

[krazyjakee]

Notes:

• Is the initial state being set using rollback? (i.e no enter/exit calls) - This would be a problem but potentially a different problem. This is a potential solution...

• When adding the character color and label text to the rollback synchronizer, it fixes the issue. It seems the state is being set but the enter and exit callbacks are not being called on the client. Do we just advise that all changes should be synced or should we dig deeper and ensure callbacks are run on the clients at the right time?