Closed Ughuuu closed 9 months ago
Will test it here: https://github.com/Ughuuu/noray/actions As it seems that here I can't run the build without approval.
Ok, works and it generates a package of this form: https://github.com/Ughuuu/noray/pkgs/container/noray docker pull ghcr.io/ughuuu/noray:pr-1
For this repo it will be docker pull ghcr.io/foxssake/noray:pr-1 Note that if using without a tag it will try to pull :latest I think, so probably you will want to use :main after main builds one docker. But no way of testing it without merging to main first I think.
Updated feedback. Locally seems ok, looks like it should work but you never know really unless you merge and it runs on main branch.(Changed that it only pushes on main branch docker and builds on both pr and main) This is the latest run: https://github.com/Ughuuu/noray/actions/runs/6995432654
You can enable the workflows to run also here to double check.
Saw this happen also locally where e2e tests would hang, but I assumed it was from my frok of the repo.
Can you rerun the e2e test please some times and see if it passes? Usually it should pass in 20s or so.
The e2e step seems to be struggling, let me look into it.
FYI this will be a "chore" commit as it doesn't affect the main application logic. Please bump the patch component in package.json.
📓 Description
Adds docker build to this and exports the docker to GitHub packages so people can run it easier.
☑️ Checklist
Updated the README
🔗 Related issues
https://github.com/foxssake/noray/issues/46