foxt / icloud.js

Library for accessing iCloud in Node.js
https://npmjs.com/icloudjs
MIT License
46 stars 4 forks source link

Make logging optional #24

Closed WeeJeWel closed 3 weeks ago

WeeJeWel commented 3 weeks ago

Thank you for this amazing library!

I'm working on a CLI utility to automate downloading iCloud Drive to a NAS.

Can the console.debug entries be replaced by the debug module, or a options.debug = console.debug parameter, so it can be disabled?

Thank you!

foxt commented 3 weeks ago

Fixed in 622f66c6a5994a1583c2cc8be9958ca34da9135d. npm isn't letting me publish right now for some reason so it's not on there just yet.

WeeJeWel commented 3 weeks ago

Wow, that was fast! Thank you! 🙏🏻

WeeJeWel commented 2 weeks ago

@foxt Could you retry publishing to npm please?

foxt commented 2 weeks ago

thanks for the reminder, should be up now.

WeeJeWel commented 2 weeks ago

Awesome, thank you!

WeeJeWel commented 2 weeks ago

There seems to be a new bug:

TypeError: this.log is not a function
    at iCloudAuthenticationStore.loadTrustToken (/Users/emile/Git/@weejewel/node-icloud-backup/node_modules/icloudjs/build/auth/authStore.js:49:18)
    at iCloudService.authenticate (/Users/emile/Git/@weejewel/node-icloud-backup/node_modules/icloudjs/build/index.js:164:24)
    at iCloudBackup.authenticate (file:///Users/emile/Git/@weejewel/node-icloud-backup/lib/iCloudBackup.mjs:63:20)
    at async iCloudBackup.backupDrive (file:///Users/emile/Git/@weejewel/node-icloud-backup/lib/iCloudBackup.mjs:84:5)
    at async Promise.all (index 0)
    at async file:///Users/emile/Git/@weejewel/node-icloud-backup/bin/icloud-backup.mjs:30:1