Move libs and added saving configuration in client

Koncord commented 10 years ago

Move RakNet,iniparser,packet,amx to source/lib Added saving configuration in client

foxtacles commented 10 years ago

looks nice, thank you, will test later ;)

Koncord commented 10 years ago

I think we need to automate search for dependencies using CMake. Maybe later I'll do it.

foxtacles commented 10 years ago

Yup, this would be nice. A few things:

amx lib doesn't compile since you added pedantic flags to the CFLAGSEXT
The clean makefile rule is missing an underscore in the code::blocks project files of amx and RakNet libs
SaveConfig function is missing HWND parameter in function implementation (doesn't compile this way)
Submodule mappings are missing. Since you moved iniparser and packet into lib folder, you need to change the .gitmodules file accordingly (see root of the repository for .gitmodules)
Since you moved these libraries, the time submodule (also a library) could be moved as well (maybe sqlite3 too)
Linker fails on vaultmp project currently with cannot find -liniparser. I think instructions to build iniparser and packet libraries are missing (unless I'm overlooking something here)

apart from that, looks good. thanks :+1:

Koncord commented 10 years ago

I think I hurried to the request. Due to problems with Github, I had to rewrite again some files. Tested on Windows and MinGW-w64 4.9.1

foxtacles commented 10 years ago

Thanks! Most issues have been fixed. There is still issue with the submodules though. It's hard to explain, but basically since submodules just reference content from another repository, you cannot put project files into these folders, so I'd suggest moving lib project and makefiles all into the lib folder (at least this needs to be done for the submodules). At the moment you have overwritten the time submodule with custom files, which needs to be fixed.

I can do this myself though if you wish (or you can try). I created a new branch "koncord" in main repository. Can you re-open this pull request (or change it if possible) so it targets the koncord branch instead of master? Then I can merge and work on it myself when necessary

foxtacles / vaultmp

Move libs and added saving configuration in client #128