search

foxy82 / hacs-onkyo-repository

Onkyo Async component to be used whilst waiting for the official version to be updated.
7 stars 0 forks source link

Integration uses deprecated magic number(s) #4

Open taw123 opened 7 months ago

taw123 commented 7 months ago

Per log: https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

Log message: Entity media_player.onkyo_avr_living_room (<class 'custom_components.onkyo_async.media_player.OnkyoAVR'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <MediaPlayerEntityFeature.VOLUME_MUTE|TURN_ON|TURN_OFF|PLAY_MEDIA|SELECT_SOURCE: 2952>, please create a bug report at https://github.com/foxy82/hacs-onkyo-repository/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

Version: HA 2024.2 Core, Docker

taw123 commented 7 months ago

First I wanted to thank you for the incredibly quick turn!

I downloaded the revised mediaplayer and log msgs are gone, and integration appears to work. Congrats....

I know this isn't the ideal place for this, however I hoped while I might have your ear I thought I would ask...

While I was digging into this I started to wonder if I could modify/customize this a bit for my receiver model. Specifically to address feature differences that don't seem to be pulled from the receiver model name/ID returned to the integration (ie number of zones and listening modes supported). I looked through miracle2k / onkyo-eiscp and he correctly has commands limited to only Zone 1, and Zone 2 for my receiver (TX-NR636). So I know that part is correct, so I was wondering if perhaps customizing media_player.py or HOPEFULLY editing the config.YAML platform definition for onkyo_async would allow me to override/correctly set both the number of zones and receiver specific/supported listening-mode(s) for the mediaplayer.sound_mode pick list.

I know one can create switches tied to scripts and drives things that way (hell I tested all this out sending raw eiscp strings and actual commands I found in miracle2k's base package, I'm just wondering if I can wire it to the default UI and code base (even if I have to hardcode this until the PR can be resurrected). 😉

Thanks again for update and any thoughts you might have about customization. --T

foxy82 commented 7 months ago

Hey. Can you raise it as a separate issue?

From what you've said the official integration works but this one doesn't? If so can you put the working config from the official integration in the issue?

foxy82 commented 7 months ago

I will also leave this issue open until I've merged this. I've not had time to test it yet.

taw123 commented 7 months ago

Makes sense to seperate and thanks for getting back to me.

I actually created a separate issue BEFORE noticing and then posting about the deprecated magic number. The issue is #3 I'll copy the relevant data from here to augment that issue as you asked.

--T