foxycms / foxycms

foxycms - Open source CMS
http://foxycms.org
GNU General Public License v2.0
0 stars 4 forks source link

Potential SQL Injection within the Authentication (via User-Agent) #3

Open datasiph0n opened 9 years ago

datasiph0n commented 9 years ago

file: classes/users.php function: authenticate($username,$password,$remember = false)

Line 108: $useragent = $_SERVER["HTTP_USER_AGENT"]; Line 116: $insert = $db->insert('users_sessions',array('user_id','ip','useragent','time','last_time','hash','remember'), array($fetch['id'],$ip,$useragent,time(),time(),$cookie_hash,$remember));

mujs commented 9 years ago

adding real_escape_string funtion inside $db->insert() would fix that I guess ?

datasiph0n commented 9 years ago

That or you could sanitize it when you declare $useragent @ line 108.