search

foxyproxy / browser-extension

Version 8 and above. Browser extension source code for Firefox, Chrome, and other Chromium-based browsers
GNU General Public License v2.0
198 stars 29 forks source link

Proxy is falling back to dafault settings when proxy is unavailable instead of blocking the request #110

Closed jeffrigby closed 5 months ago

jeffrigby commented 6 months ago

I have a proxy configuration that points to a local stunnel. In previous versions, if stunnel was not started, I would get an error. In the newest version, if stunnel is disabled the browser ignores it and sends the request with the default firefox settings, bypassing the proxy. This is a security risk for me. It's essential that when the proxy is enabled, no requests are sent outside of the proxy.

I have a standard wildcard to catch all URLs.

I see in the log that it tries the proxy and then falls back (see image)

As soon as I start stunnel, the requests are proxied correctly. Nothing has changed with my configuration, so I'm not sure when this started. proxySettings log

erosman commented 6 months ago

FoxyProxy does not set a fallback process. FoxyProxy tells the browser (Firefox in this case) to process abc request via xyz proxy. From then on, everything is handled by the browser.

FoxyProxy is not aware if the proxy server is responding or not.

FoxyProxy v7.5.1 had a similar process in matcher.js, so there shouldn't be a difference in behaviour between v7.5 & v8.8

ericjung commented 6 months ago

can you share your patterns and settings? I can try to reproduce. it looks like you have more than one proxy defined. are you using "proxy by patterns" or another mode? Too many questions to ask. We need your settings.

jeffrigby commented 5 months ago

This has fixed itself. I didn't change anything directly, but it returned to denying the request if stunnel was down. Firefox updated, and I restarted. Unfortunately, I have no idea why it stopped working or started working again.