foxyproxy / browser-extension

Version 8 and above. Browser extension source code for Firefox, Chrome, and other Chromium-based browsers
GNU General Public License v2.0
198 stars 29 forks source link

"Disabled" profile is automaticly selected after changing the IP/port of the active proxy profile #116

Open sh3ll4rpw opened 5 months ago

sh3ll4rpw commented 5 months ago

I use socks5. When my proxy dies, I always replace the socks by editing the current active profile. No problem if I had multiple tabs open. When I do that with the new Foxyproxy, it automatically selects the disabled profile after changing the IP/port of the active profile and the connection doesn't go through the proxy anymore which is a security risk. It doesn't matter if I give the socks a title. Please fix this issue

erosman commented 5 months ago

Please note:

Every time an edit is made, new set of proxies are created. FoxyProxy then looks for the proxy that was set before and if it doesn't find it, it won't know which proxy the user intends to use, so it sets itself to disabled. In that case, user will have to select the desired proxy.

Please also note from FoxyProxy Help:

[!WARNING] If FoxyProxy is to set to use an Individual Proxy/PAC, editing proxy's hostname, port, or PAC URL, may result in a mismatch until it is set again.

sh3ll4rpw commented 5 months ago

Ok that is ridiculous in my opinion. It's a security risk and that behavior have no single benefit at all. Are you willing to fix it? otherwise I have to change back to the old version

erosman commented 5 months ago

When a user changes proxy1:port1 to proxy2:port2, the first proxy is deleted and a new proxy is created. Proxy1 & Proxy2 are two different proxies.

sh3ll4rpw commented 5 months ago

Depending on what proxies you use, proxies die all the time. It's much easier to edit the current proxy. Do you really expect users to create a new proxy, select it and delete the old one if they want to change a proxy? With the need to remind they can't edit the current proxy because it will leak IP or whatever. All that instead of simply editing. That is crazy.

I saw your topic about UI. You also made it 1 more click to edit a proxy. In total you made it like 5 more clicks to replace a proxy + a lot of space for human error + forcing people to remind not editing a proxy.

Many people use proxies for SECURITY, like how Foxyproxy also sells VPN. As coder of a security product it is your task to eliminate human error as much as possible. Its not like the person is doing something strange and out of scope for regular users. You're adding human error to one of the most common practices of Foxyproxy. Please put in work and change back to proxy by profile and not proxy by proxy.