Incorrect import of a proxy with `socks` protocol

[lessneek]

On Import Proxy List a proxy with socks:// protocol is imported with empty hostname and port.

Versions:

Firefox 121.0.1
FoxyProxy 8.8

[erosman]

Can you give an example?

I tried with these and there were no problems.

socks://100.10.11.12:1080?title=China&cc=CN&city=Beijing
socks5://100.10.11.12:1080?title=China&cc=CN&city=Beijing

[lessneek]

I've tried these:

socks://100.10.11.12:1080?title=China&cc=CN&city=Beijing
socks5://100.10.11.12:1080?title=China&cc=CN&city=Beijing

and what I've got:

[lessneek]

A breakpoint while debugging: it seems that the URL doesn't parse a socks:// url correctly:

[erosman]

Which version of FoxyProxy are you using and which browser?

[lessneek]

Which version of FoxyProxy are you using and which browser?

Firefox 121.0.1 FoxyProxy 8.8 Fedora Linux 39 (Workstation Edition)

[erosman]

I tested it now with v8.8 on Firefox Nightly and I don't get any problems.

Please try the following:

• Export your settings (to have a back-up)
• Uninstall FoxyProxy (better to restart Firefox after to clear its cache)
• Reinstall FoxyProxy
• Test again

[lessneek]

I have tries with an empty Firefox this in console, and it seems that a URL with the socks protocol is not parsed correctly. I can replace socks with asdf and the result will be the same (but https works as expected):

I don't know how the URL is implemented, but it seems that it is based on my current system installation. Can you try it in Fedora 39 may be?

I found that there were some regressions in the past few years, but it was fixed, may be it is a new regression. Have no time to make a research of it.

[lessneek]

May be we can replace the URL parsing method with a simple regular expression? Just to have no dependence of a particular system configuration.

[erosman]

I have tries with an empty Firefox this in console, and it seems that a URL with the socks protocol is not parsed correctly.

That is why FoxyProxy code reprocesses it. I don't get any error when I try it.

• The code checks if protocol is http: or https:
• if not:
  • Sets the type according to the protocol
  • Changes the protocol to http:
  • Runs new URL(url) again with http:

https://github.com/foxyproxy/browser-extension/blob/172c936be1f6ffa4450f5e5186c48794aa8037ba/src/content/options.js#L1019-L1041

[lessneek]

Sets the type according to the protocol

when I debug, protocol isn't changed after assignment:

url = new URL("socks://10.10.1.2:1080")
< URL { href: "socks://10.10.1.2:1080", origin: "null", protocol: "socks:", username: "", password: "", host: "", hostname: "", port: "", pathname: "//10.10.1.2:1080", search: "" }

url.protocol = "http"
< "http"

url
< URL { href: "socks://10.10.1.2:1080", origin: "null", protocol: "socks:", username: "", password: "", host: "", hostname: "", port: "", pathname: "//10.10.1.2:1080", search: "" }

[erosman]

You are right. :man_facepalming: I have tested it on Chrome and Firefox and while Chrome allows changing the protocol, Firefox doesn't. I am going to ask Mozilla for a reason and rewrite the code accordingly.

(() => {
  let url = new URL("socks://10.10.1.2:1080");
  console.log(url);

  url.protocol = 'http:';
  console.log(url);
})();

[erosman]

I have updated the code with a fix for v8.9.

[erosman]

It seems new URL() has changed.

On Firefox 121.0.1, hostname & port are not shown.

On Nightly 124.0a1, hostname & port are shown.

[erosman]

It seems new URL() was updated in Firefox 122 (Bug 1603699: Enable DefaultURI use for unknown schemes).

[erosman]

v8.9 uploaded to AMO Basic version is available now and the standard version will be available after the AMO review.