search

foxyproxy / browser-extension

Version 8 and above. Browser extension source code for Firefox, Chrome, and other Chromium-based browsers
GNU General Public License v2.0
199 stars 29 forks source link

Extension functionality is broken for non-PAC proxies #41

Closed chromer030 closed 7 months ago

chromer030 commented 7 months ago

Hello, Thanks for efforts in making this extension better and better.

I tested latest git on Chrome, it doesn't work on anything else than PAC.

Selecting PAC proxies are working but by selecting any normal proxiy nothing happens

erosman commented 7 months ago

I updated the repo today. Was that the version that you tested?

PS. I found an issue which I fixed and updated the repo.

chromer030 commented 7 months ago

Tested and confirm it fixed in 2e2033245317bee04e210d4200f8917ff2c02e54

Thanks very much.

chromer030 commented 7 months ago

@erosman Now Direct is broken, proxies all work except Direct.

erosman commented 7 months ago

Thank you. I am reworking some parts of the code. I will check that.

Update I found the issue. I will fix it and update the repo. Thank you for beta testing it on Chrome.

chromer030 commented 7 months ago

Tested, extension is broken again completely in latest git, PACs are also broken

chromer030 commented 7 months ago

Randomly hard reset to this commit 0056c56002e30f76f067eb123281eefb67df1b17 and all proxies are working.

git reset --hard 0056c56002e30f76f067eb123281eefb67df1b17

erosman commented 7 months ago

Tested and confirm it fixed in 2e20332

That commit was from Nov 9, 2023

Randomly hard reset to this commit https://github.com/foxyproxy/browser-extension/commit/0056c56002e30f76f067eb123281eefb67df1b17 and all proxies are working.

Above commit is from Oct 18, 2023.

What was the last commit that was working? What is broken exactly? Can you select proxies?

Update I did a quick test now on Chrome with the latest commit and it seems to be working.

chromer030 commented 7 months ago

Now i tried with latest commit : 29ab2e4ce10e06e126c623207c095ed1fa26861e and really something is wrong, i thought maybe the backup file makes the issue, so tested with following procedures:

1- Git clone & rename chrome-manifest.json to manifest.json & remove other manifests. 2- Chrome > about:extensions > Pack Extension 3- Install generated src.crx 4- Add an example Socks5 proxy 5- Add and example Direct proxy 6- Select proxies 7- none of them work, proxy doesn't apply (IP is local)

What is broken exactly?

Proxies doesn't apply.

Can you select proxies?

No, this is exactly the issue as you can see in recorded video:

OS : Linux Browser : Google Chrome 119

erosman commented 7 months ago

I am not sure if it is the issue, but can you try to install the extension according to the Installation Guide (for testing) i.e. "Load Unpacked".

I am also on Ubuntu 23.10 & Chrome 119.

chromer030 commented 7 months ago

Still the issue persists

Please pay attention to foxyproxy icon on toolbar when i change the proxies, nothing changes there!, means proxy switching is broken.

erosman commented 7 months ago

Sorry about that.. there was a bug in the previous update. Please try now.

chromer030 commented 7 months ago

Please try now.

Tested, Working & no issue anymore.

Appreciate your efforts.

erosman commented 7 months ago

FoxyProxy Basic 8.1 has been uploaded to Chrome store and will be available shortly.