foxyproxy / browser-extension

Version 8 and above. Browser extension source code for Firefox, Chrome, and other Chromium-based browsers
GNU General Public License v2.0
227 stars 33 forks source link

Authenticated SOCKS5 proxy not working in Chromium #52

Closed unrealtournament closed 9 months ago

unrealtournament commented 9 months ago

I have installed the extension on the latest Chromium (Version 120.0.6099.71 (Official Build) (64-bit)), after adding a SOCKS5 proxy with user/pass authentication and enabling it all connections fail with the following message.

image

The proxy is from Private Internet Access (more information on hostnames/IPs/ports here https://helpdesk.privateinternetaccess.com/kb/articles/do-you-offer-a-socks5-proxy), I've exported my working configuration from Firefox and imported it into chromium, so the proxy itself is working just fine on the same version of FoxyProxy on Firefox. I've also tried the proxy manually with curl and it works fine as expected.

Here is another screenshot showing the exact same FoxyProxy config on both Firefox and Chromium, and the proxy only working with Firefox:

image

Things I've tried without success:

If there is any additional log or information I can provide I'd be happy to do so. OS is Windows 10 x64.

ericjung commented 9 months ago

I am fairly sure Chrome never natively supported authentication with SOCKS5 servers. If so, username/password should be disabled on chrome when SOCKS5 server is setup or imported from Firefox; it has to be supported by the browser for it to work.

I will double-check this and reply again.

unrealtournament commented 9 months ago

I see, if that is the case it should probably be reflected in the UI somehow as you said, as right now it allows you to enter a user/password. Thank you anyway.

erosman commented 9 months ago

Chrome never supported SOCKS5 authentication. In fact, Firefox is the only browser that has an API to support SOCKS5 authentication.

It is outlined in FoxyProxy Help under "Proxy Authentication".

FoxyProxy 8 has a unified code on Chrome & Firefox, enabling users to import/export settings between browsers.

randomstuff commented 9 months ago

For reference see Proxy support in Chrome:

No authentication methods are supported for SOCKSv5 in Chrome (although some do exist for the protocol).

ericjung commented 9 months ago

Chrome never supported SOCKS5 authentication. In fact, Firefox is the only browser that has an API to support SOCKS5 authentication.

It is outlined in FoxyProxy Help under "Proxy Authentication".

FoxyProxy 8 has a unified code on Chrome & Firefox, enabling users to import/export settings between browsers.

  • Removing the data when importing would interfere with sharing between browsers
  • Removing the data would also interfere with proxy type switching
  • Removing the UI in Chrome will affect editing and sharing between browsers
  • Disabling the UI can result in user/pass showing in imported settings and no way to edit it

We can warn the user when importing into chrome settings with a socks proxy server with authentication. If we don’t do anything at all (like now), I expect more tickets like this in the future.

erosman commented 9 months ago

We can warn the user when importing into chrome settings with a socks proxy server with authentication. If we don’t do anything at all (like now), I expect more tickets like this in the future.

I will update the UI for v8.5