foxyproxy / browser-extension

Version 8 and above. Browser extension source code for Firefox, Chrome, and other Chromium-based browsers
GNU General Public License v2.0
227 stars 33 forks source link

[Improvement] Bring back the display of disabled templates in the popup window #56

Closed nlboom closed 9 months ago

nlboom commented 9 months ago

A handy feature of this extension has disappeared in newer versions. I use several proxy templates, most of the time they are disabled, but sometimes I need to enable forced proxying from a specific template for all addresses. In FoxyProxy 7.5.1 this could be done in a popup window, in 8.2 the template is not shown if it is turned off. Now I have to go to the settings and turn on the template there first and then in the popup window, which is inconvenient

erosman commented 9 months ago

There were other users, with 10s of disabled proxies, who requested the removal of disabled proxies from the popup UI as it caused clutter and lengthy scrolling to find the right proxy.

sometimes I need to enable forced proxying from a specific template for all addresses.

There should be no need to disable a proxy that is used "for all addresses". Such proxy would not need any patterns and therefore it wouldn't interfere with other operations by being enabled.

nlboom commented 9 months ago

I think you should add a function to the template settings to display yes/no disabled proxy in the selection window.

erosman commented 9 months ago

There is no function in the popup to enable disabled proxies, even if they are displayed in the popup. Would there be a use to show them?

nlboom commented 9 months ago

I think that would be redundant. Do it only on the settings page.

nlboom commented 9 months ago

@erosman Hi. Have you already made the changes to the extension as per my request? Because I updated and nothing changed.

erosman commented 9 months ago

When I asked what would the benefit of having disabled proxies in the popup, I thought you agreed that there was no benefit.

What would be the benefit of showing them in the popup?

nlboom commented 8 months ago

@erosman

What would be the benefit of showing them in the popup?

I wrote in the first post why this is important to me. Since some users were unhappy that disabled proxies are displayed in the menu, I suggest adding a customization: "display proxy in the FoxyProxy menu even when it is turned off". You can make it be turned off by default. Here's an example: изображение

erosman commented 8 months ago

There is no mechanism to enable or select a disabled proxy from the toolbar popup.

What would be the benefit of creating additional options in the settings and displaying the disabled proxies on the toolbar popup? It will only be there for show.