foxyproxy / browser-extension

Version 8 and above. Browser extension source code for Firefox, Chrome, and other Chromium-based browsers
GNU General Public License v2.0
199 stars 29 forks source link

Problem with 'local' tld and domains in 8.6 #82

Closed vx-github closed 6 months ago

vx-github commented 6 months ago

After the update to 8.2 FoxyProxy Standard for Firefox and not soon after to 8.6, I got problems with URLs that contained local in the hostname part of the URL.

So I rolled back to 7.5.1 and created a proxy with the follow (White) paterns:

When testing the following URLs:

Then I did an upgrade to 8.6, and tested the same URLs (did a Firefox restart in between). Now only the https://test123.domain.nl/ was send to the proxy and the URLs that contained localwere not.

I consider this a bug since our organization uses .local domains for internal use (unfortunately) and this tld and domains were still working on 7.5.1.

erosman commented 6 months ago

Are you using "Proxy by Patterns" or individual proxy? Can you post a screenshot of the patterns that you have set for the above domains in FoxyProxy 8?

vx-github commented 6 months ago

I used "Proxy by Patterns" (like I used "Use Enabled Proxies By Patterns and Order" in 7.5.1).

Screenshot attached:

Screenshot 2023-12-12 at 14 20 36
erosman commented 6 months ago

Does the Log have any useful information?

Also ...

vx-github commented 6 months ago

The logging of FoxyProxy shows which URL request are send to the proxy and which are not (mentioned in the issue). No other usefull info.

The used URLs aren't supposed to work. they are constructed so I can see if they are passed to the proxy (seen in the FoxyProxy logging). The result in the browser also gives a clue if a URL is tried to (DNS) resolve or if it is passed to the proxy and the proxy cannot find it.

I rolled back to 7.5.1 and for every test I need to upgrade to 8.6 and roll back again to 7.5.1 (to be able to work again). So you last 'Also ...' request will be done later.

BTW: I'm on Firefox 120.0.1 on MacOs.

vx-github commented 6 months ago

< cut > typo in test URL, will have to redo this

erosman commented 6 months ago

The error shows DNS error. Firefox cant resolve the NS record for the domain. The DNS is not something that FoxyProxy handles. It is handled by the browser.

Have you enabled DoH (DNS over HTTPS)? Have you enabled Proxy DNS? (although I cant see that affecting the outcome) Have you tried nslookup in the MacOS terminal?

nslookup test123.local.nl
vx-github commented 6 months ago

I made a typo in the last test, so the outcome did not reflect the problem. I will post a new screenshot.

erosman commented 6 months ago

Are you still having the issue with the latest release?

vx-github commented 6 months ago

@erosman I updated Firefox to 121.0 and FoxyProxy to 8.8 and I cannot reproduce the original problem anymore and a quick test shows everything is working as expected again.