search

foxythemes / jira-cli

A jira user friendly command line client
https://jiracli.com
MIT License
204 stars 41 forks source link

Feat: adds proxy configuration #15

Closed renato-bohler closed 6 years ago

renato-bohler commented 6 years ago

This PR adds the option to configure the proxy that should be used to make calls to JIRA API.

The commands that I've added are jira config proxy, jira config proxy (proxy address here) and jira config proxy remove:

jira-cl

I'm not updating the package version (I believe it should go to 1.1.0 as this is a new feature), and I don't have the access to add this new command to the documentation page.

Fixes #14.

renato-bohler commented 6 years ago

Is there anything preventing this PR to be merged?

miguelmich commented 6 years ago

I'm sorry @renato-bohler I just arrived from vacations today, I'm going to make the review tomorrow and merge it!

thanks :)

renato-bohler commented 6 years ago

Oh, no problems. I thought you were thinking that it was accepted.

Thanks