Closed MrCroxx closed 4 weeks ago
Attention: Patch coverage is 87.67123%
with 9 lines
in your changes missing coverage. Please review.
Files with missing lines | Coverage Δ | |
---|---|---|
foyer-storage/src/device/direct_file.rs | 85.16% <100.00%> (+0.24%) |
:arrow_up: |
foyer-storage/src/device/direct_fs.rs | 88.06% <100.00%> (+0.20%) |
:arrow_up: |
foyer-storage/src/large/generic.rs | 89.83% <100.00%> (-0.06%) |
:arrow_down: |
foyer-storage/src/large/scanner.rs | 75.42% <100.00%> (-0.28%) |
:arrow_down: |
foyer-storage/src/large/tombstone.rs | 96.55% <100.00%> (ø) |
|
foyer-storage/src/small/generic.rs | 74.61% <100.00%> (-0.27%) |
:arrow_down: |
foyer/src/hybrid/builder.rs | 95.15% <100.00%> (ø) |
|
foyer/src/hybrid/cache.rs | 82.66% <100.00%> (-0.11%) |
:arrow_down: |
foyer-storage/src/device/monitor.rs | 81.00% <80.00%> (+2.35%) |
:arrow_up: |
foyer-storage/src/store.rs | 86.81% <81.81%> (ø) |
|
... and 2 more |
What's changed and what's your intention?
Make sure can use
XxxDeviceOptions
directly withwith_device_options()
. The old builder looks so wired.Checklist
make all
(ormake fast
instead if the old tests are not modified) in my local environment.Related issues or PRs (optional)
327