Closed MrCroxx closed 2 weeks ago
Attention: Patch coverage is 89.62264%
with 11 lines
in your changes missing coverage. Please review.
Files with missing lines | Coverage Δ | |
---|---|---|
foyer-storage/src/small/flusher.rs | 85.00% <100.00%> (-0.30%) |
:arrow_down: |
foyer-storage/src/small/set.rs | 94.15% <ø> (-0.02%) |
:arrow_down: |
foyer-storage/src/small/set_cache.rs | 100.00% <100.00%> (ø) |
|
foyer-storage/src/small/generic.rs | 75.14% <66.66%> (+0.52%) |
:arrow_up: |
foyer-storage/src/store.rs | 85.33% <42.85%> (-0.73%) |
:arrow_down: |
foyer-storage/src/small/set_manager.rs | 90.28% <92.18%> (+1.96%) |
:arrow_up: |
What's changed and what's your intention?
FYI: #759
Lock Order:
load (async set cache, not good):
load (sync set cache, good):
update:
Checklist
make all
(ormake fast
instead if the old tests are not modified) in my local environment.Related issues or PRs (optional)
close #759