foyzulkarim / mern-video-streaming

MERN Video Streaming is a cutting-edge, open-source platform for video streaming, offering a comprehensive, full-stack solution utilizing the latest MERN stack technologies.
MIT License
182 stars 63 forks source link

client hosted on vercel #56

Closed mohammadShamimReza closed 1 year ago

mohammadShamimReza commented 1 year ago

I just host the client to vercel here is the link: https://mern-video-streaming.vercel.app/videos

foyzulkarim commented 1 year ago

Thanks for your PR brother, but how will this pull request help the repository to automatically deploy to vercel?

mohammadShamimReza commented 1 year ago

sorry brother, I just wanna inform you that i deploy the client to vercel and give the link through this pull request.

I read vercel docs that if any code push in github (main) it will automatically deploy again.

if I have done the wrong thing please tell me. I will make it correct

foyzulkarim commented 1 year ago

Thanks for the reply. What I want to know is, if there is any config thing which we can add to the github repository? So that i will just add my Tokens to that config file and it will automatically do the deployment to vercel.

If there is nothing like this type of config file, then you can add some explanation about your findings.

mohammadShamimReza commented 1 year ago

Thanks,

I think the answer is here: https://vercel.com/docs/concepts/deployments/git#deploying-forks-of-public-git-repositories https://vercel.com/docs/concepts/deployments/git/vercel-for-github#deployment-authorizations-for-forks

foyzulkarim commented 1 year ago

Brother, taking the lead means providing guideline and summary what can be done next. If possible, write some note why you think adding a vercel config is possible or not possible so that we can come to a conclusion. Sending the link is not a good way of communication because I don't have any context about vercel deployment via github repository.

foyzulkarim commented 1 year ago

when you complete your changes, please use the label ready for review

mohammadShamimReza commented 1 year ago

Ok, the thing is vercel deployment work automatically when code is pushed in github. if the project is deployed through github. Means When a public repository is forked, commits from it will usually deploy automatically. However, when you receive a pull request from a fork of your repository that includes a change to the [vercel.json] file or the project has [Environment Variables], Vercel will require authorization from you or a [Team Member] to deploy the pull request. This is a security measure that protects you from leaking sensitive project information. A link to authorize the Deployment will be posted as a comment on the Pull Request.

The authorization step will be skipped if the commit author is already a [Team Member] on Vercel.

There is no setting option for adding a label

foyzulkarim commented 1 year ago

So, we can close this issue as it it not feasible and not important for now. Thanks @mohammadShamimReza brother for the effort.