search

foyzulkarim / mern-video-streaming

MERN Video Streaming is a cutting-edge, open-source platform for video streaming, offering a comprehensive, full-stack solution utilizing the latest MERN stack technologies.
MIT License
182 stars 63 forks source link

Implemented generic `deleteById` #59

Closed ysnarafat closed 1 year ago

ysnarafat commented 1 year ago

closes #54

foyzulkarim commented 1 year ago

where are the changes of model's service files? you should test this from postman.

check my videos to understand the completeness of the work.

when you complete your changes, please use the label ready for review

ysnarafat commented 1 year ago

where are the changes of model's service files? you should test this from postman.

check my videos to understand the completeness of the work.

when you complete your changes, please use the label ready for review

I tested with services all the way from controller through postman. But thought only implementing the generic method was the scope of the issue.

Okay, I am pushing the required changes.

foyzulkarim commented 1 year ago

I think you will not have permission to change the label. Please add a comment when you are done. I will review it again after that. 🙂

ysnarafat commented 1 year ago

I think you will not have permission to change the label. Please add a comment when you are done. I will review it again after that. 🙂

Yes, I don't have permission to add label. I am requesting again for review.

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @foyzulkarim on Vercel.

@foyzulkarim first needs to authorize it.