Wordsi-Update code review

fozziethebeat / S-Space

The S-Space repsitory, from the AIrhead-Research group

GNU General Public License v2.0

205 stars 106 forks source link

Wordsi-Update code review #1

Closed fozziethebeat closed 13 years ago

fozziethebeat commented 13 years ago

Incorporate the wordsi-update branch into the trunk. This branch includes the following major changes

A complete overhaul of the clustering package. This includes many new clustering methods and an in-house implementation of Direct K-Means clustering as provided by Cluto
- A framework for doing word sense induction using streaming and batch clustering methods. Several feature spaces are included, as are mains for each of these feature spaces
- A variety of bug fixes
- Refactoring of the matrix transform classes. They are now much simpler and more separated so that writing new transforms requires significantly less effort
- Refactoring of the basis mappings to provide more functionality and centralize implementation details
- Adding more javadoc and licenses to files
- A lot of new unit tests to both existing code and new codes

fozziethebeat commented 13 years ago

Malarky that was a lot of good suggestions. I've committed and pushed everything so you should be able to see them (i'm curious to see how that looks).

A bunch of them are TODOs so i'm going to handle those monday when i'm not overly tired.

fozziethebeat commented 13 years ago

Second set of code review fixes committed.

fozziethebeat commented 13 years ago

Wow, that was magical. I merged everything with a single button!

davidjurgens commented 13 years ago

Is that checked into the SVN trunk as well now?

On Tue, Aug 23, 2011 at 2:00 PM, fozziethebeat < reply@reply.github.com>wrote:

Wow, that was magical. I merged everything with a single button!

Reply to this email directly or view it on GitHub: https://github.com/fozziethebeat/S-Space/pull/1#issuecomment-1883979

fozziethebeat commented 13 years ago

not yet. I can do that now if you want, but there are actually a few smaller changes that i've recently made into new branches that I want your thoughts on. If you like those, then we might as well save time and copy over just one large diff rather than a handful of them.

fozziethebeat commented 13 years ago

https://github.com/fozziethebeat/S-Space/pull/3 is one such branch. This has the corpus reader changes that I pulled out of the wordsi-update.

davidjurgens commented 13 years ago

Commented! Also, interesting fact that github's comments eat html markers so commenting on templated code requires using >

On Tue, Aug 23, 2011 at 2:45 PM, fozziethebeat < reply@reply.github.com>wrote:

https://github.com/fozziethebeat/S-Space/pull/3 is one such branch. This has the corpus reader changes that I pulled out of the wordsi-update.

Reply to this email directly or view it on GitHub: https://github.com/fozziethebeat/S-Space/pull/1#issuecomment-1884431