fp7-netide / Engine

App Engine to enable Network App programs to be executed, systematically tested, and refined on a variety of concrete SDN platforms
Eclipse Public License 1.0
10 stars 11 forks source link

Syntax Error in Netip.py library #117

Closed sergiotamu closed 8 years ago

sergiotamu commented 8 years ago

Hello,

There is a syntax error in the netip.py library. From line 73 to 87 we have these lines of code:

    NetIDE_type = {
        'NETIDE_HELLO'          : 0x01,
        'NETIDE_ERROR'          : 0x02,
        'NETIDE_MGMT'           : 0x03,
        'NETIDE_MODULE_ANN'     : 0x04,
        'NETIDE_MODULE_ACK'     : 0x05,
        'NETIDE_HEARTBEAT'      : 0x06,
        'NETIDE_TOPOLOGY'       : 0x07,
        'NETIDE_FENCE'          : 0x08,
        'NETIDE_OPENFLOW'   : OPENFLOW_PROTO,
        'NETIDE_NETCONF'    : NETCONF_PROTO,
        'NETIDE_OPFLEX'     : OPFLEX_PROTO
        'NETIDE_OFCONFIG'   : OFCONFIG_PROTO
        'NETIDE_OTHER'      : OTHER_PROTO
    }

So, lines 84 and 85 are not correct since there is a missed comma at the final of the line:

        'NETIDE_OPFLEX'     : OPFLEX_PROTO
        'NETIDE_OFCONFIG'   : OFCONFIG_PROTO

If you want I can modify it

Thank you! Sergio

doriguzzi commented 8 years ago

It should be fixed now.

Thanks

--rob