Fixed problems with sys_error exception

fpagliughi / sockpp

Modern C++ socket library.

BSD 3-Clause "New" or "Revised" License

782 stars 126 forks source link

Fixed problems with sys_error exception #20

Closed snej closed 5 years ago

snej commented 5 years ago

sys_error couldn't be caught as a std::exception because it didn't publicly inherit from it.
inet_address should not throw a sys_error when getaddrinfo() fails, because getaddrinfo doesn't set errno and doesn't use the same error numbers as errno. Created a new exception class for it.
Fixed a memory leak in inet_address::resolve_name.

Fixes #18, fixes #19

fpagliughi commented 5 years ago

Awesome again. I don't have time to test or work on this for the next few days, but this looks pretty good. I can say, for one, that sys_error not publicly inheriting from std::exception was a mistake/bug on my part. It should have been from the start.

fpagliughi commented 5 years ago

This doesn't build on Windows.

sockpp.git\src\exception.cpp(41): fatal error C1083: Cannot open include file: 'netdb.h': No such file or directory[sockpp.git\build\src\sockpp-objs.vcxproj]
  inet_address.cpp
sockpp.git\src\inet_address.cpp(67): error C2065: 'EAI_SYSTEM': undeclared identifier [sockpp.git\build\src\sockpp-objs.vcxproj]

I'll see if I can figure it out.

fpagliughi commented 5 years ago

OK. Cool. I fixed this and merged it into the 'develop' branch. I did the following:

I included "sockpp/platform.h" in exception.cpp instead of . This has the proper system header files for each platform.
The error 'EAI_SYSTEM' does not exist in Windows, nor does there appear to be an equivalent, so I conditionally compiled that check for non-Windows systems only.
The exact same bugs that this PR fixed also appeared in inet6_address. So I fixed those as well in an identical fashion.

We should write some unit tests to make sure this behaves as expected.

Thanks again!