search

fpagliughi / sockpp

Modern C++ socket library.
BSD 3-Clause "New" or "Revised" License
769 stars 126 forks source link

fix: android strerror #55

Closed bmahlbrand closed 2 years ago

bmahlbrand commented 3 years ago

Fix for #52

paulocoutinhox commented 3 years ago

It will be merged?

talregev commented 2 years ago

I think this fix is better then my Fix. I hope it will be merge. but it seems that this repo is not active anymore.

fpagliughi commented 2 years ago

Sorry, I haven't gotten back to this library in a while, but I plan to soon. Apologies for the delay.

talregev commented 2 years ago

Thank you for responding. I create a PR to add a patch to vcpkg to compile this lib on Android

talregev commented 2 years ago

https://github.com/microsoft/vcpkg/pull/19769

talregev commented 2 years ago

@fpagliughi, I updated the port in vcpkg. https://github.com/microsoft/vcpkg/pull/19769 They are waiting for your approval. If you approve this change (even before the pull request approve), they will approve my PR. Then in the next release, I will remove the patch (if needed).

talregev commented 2 years ago

@fpagliughi any news?

fpagliughi commented 2 years ago

Yes, sorry. I've had little time to work on open source this past year. I'll get this in a quick release of some minor updates now.

paulocoutinhox commented 2 years ago

Nice, no problem. Thanks.