Allow absolute/system-wide path

fpanaccia / Wkhtmltopdf.NetCore-deprecated

Rotativa + Net Core

The Unlicense

220 stars 94 forks source link

Closed gurustron closed 4 years ago

gurustron commented 4 years ago

Added IWkhtmltopdfPathProvider and few implementations, including ExactPathProvider allowing users to provide any path including system-wide one.
Marked old DI method as obsolete. Added new one requiring IMvcBuilder.
Introduced IWkhtmlDriver.

gurustron commented 4 years ago

@fpanaccia Just FYI: Needed to add next to the github actions so tests will be able to pass :

    - name: CHMOD
      run: chmod +x Wkhtmltopdf.NetCore/Rotativa/Linux/wkhtmltopdf

fpanaccia commented 4 years ago

@gurustron is this PR ready? because im gonna do another modifications and i dont want to generate conflicts

gurustron commented 4 years ago

@fpanaccia yes, it is ready for review and if you don't have any objections - merging =)

fpanaccia commented 4 years ago

Perfect! I have a few concerns, but dont worry i will merge it, and review it.

Thanks for your great work!

gurustron commented 4 years ago

@fpanaccia my pleasure!