search

fpanaccia / Wkhtmltopdf.NetCore-deprecated

Rotativa + Net Core
The Unlicense
220 stars 94 forks source link

Request - remove MVC dependency #4

Closed akdor1154 closed 5 years ago

akdor1154 commented 5 years ago

The core functionality of this library does not require MVC at all, it makes me a bit sad to have to pull in all of AspNetCore.MVC anyway. (I want to use it in an old .NET Framework project that's still on MVC4). Happy to submit a pull request but it would probably consist of moving the MVC-dependent code into your example project or something, which seems a bit invasive for a drive-by PR to your project. :)

fpanaccia commented 5 years ago

Hi, sorry for the delay, i understand your requirement, but i need the library to work this way (at least for now). I guess i could do another nuget, with the mvc part alone, but as you can see i already engage in a change for the library, maybe for another release.

akdor1154 commented 5 years ago

No worries! :) i just wrote my own wrapper, was a very small amount of code.

fpanaccia commented 5 years ago

yeap, the core functionality it is just one class