search

fpanaccia / Wkhtmltopdf.NetCore-deprecated

Rotativa + Net Core
The Unlicense
220 stars 94 forks source link

Redirect stdin/stdou on linux container #54

Open CarlosArmiliato opened 3 years ago

CarlosArmiliato commented 3 years ago

Hi,

I'm using this project and i testd linux stdout redirection. If i'm running on Linux OS, this project wil write html on file and read from there to generated PDF file.

I believe it is because stdin/stdou redirection wont be working in the past. But i'm test now, with the last .Net5, and that work fine.

I only remove the else clausule, and alow the program perform the same code to Windows and Linux OS. On the WkhtmlDriver class, the else reference if clausule on line 40: if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX))

I think use stdin/stdou redirection are better then write and read from the disk.

Wath do you think about remove that "if" as i did? Can i open pull request with this modification?