search

fpco / cosmos-rs

Library and CLI tool for interacting with Cosmos chains over gRPC
MIT License
2 stars 3 forks source link

Investigate potential Ledger integration #2

Open snoyberg opened 6 months ago

snoyberg commented 6 months ago

It would be convenient to be able to sign transactions using a Ledger hardware wallet. Currently such signing tends to happen in web apps instead. A very quick investigation pointed me to this:

https://lib.rs/crates/ledger-cli

nubis commented 6 months ago

I may get into this. But I thought this cosmos-rs library was for backend services. What would be the use case for signing with ledger? Is it for hooking up a ledger as an unattended HSM? If so, the unattended part is tricky, I doubt the generic cosmos app supports this, so a new app may be needed.

snoyberg commented 6 months ago

This would be for command line usage. The main reason for this is to be able to do things like signing multisig proposals from the CLI without needing to use some web app. And the reason to avoid the web apps is that we've had lots of cases where the web apps have broken due to node issues or chain API breakages, while the CLI tooling tends to be much more reliable.

nubis commented 6 months ago

oh, I can look at it, what's the priority?

Also: I could probably add trezor too.

snoyberg commented 6 months ago

Low priority, a nice to have when we don't have other things to do.

I don't think Trezor has Cosmos support.

nubis commented 6 months ago

got it, I'll keep it in the backburner. Regarding trezor (and other hw wallets) and Cosmos, I guess it will depend on which cosmos blockchain we're talking about, most of the wallets can be coherced to at least sign Secp256k1.