search

fpco / ide-backend

ide-backend drives the GHC API to build, query, and run your code
120 stars 17 forks source link

Backport RTS fixes to GHC 7.4 #226

Closed snoyberg closed 10 years ago

snoyberg commented 10 years ago

This is to avoid any forkProcess deadlocks when using GHC 7.4.

snoyberg commented 10 years ago

Pinging @manny-fp, we'll need to build a new GHC 7.4 for this (not sure if we'll need a new environment). Not necessary for the 3.0 beta we're giving Amgen, since they'll be using 7.8 exclusively.

edsko commented 10 years ago

(Have just pushed a fix for https://ghc.haskell.org/trac/ghc/ticket/9377 to the ide-backend-expermental-78 branch so it will probably be useful to rebuild that, too.)

borsboom commented 10 years ago

@snoyberg Is there any need to rebuild the GHC 7.4 unstable environment? Otherwise I'll just rebuild the stable 7.4 environment and remove the unstable 7.4 environment (7.8 becomes the new unstable).

snoyberg commented 10 years ago

Yes, that's fine with me.

edsko commented 10 years ago

I have pushed the backports for 7.4, but I recommend holding off on rebuilding for just a bit because am getting one spurious test result that I would like to look at first (#228).

borsboom commented 10 years ago

@edsko It looks like #228 is closed. Should I go ahead with rebuilding now?

edsko commented 10 years ago

@manny-fp Yes, go ahead; this did/does not require any changes to ghc.

borsboom commented 10 years ago

@edsko Are you saying I don't need to rebuild GHC at all, or just that there were no GHC changes for #228 but it still needs a rebuild for the backports?

borsboom commented 10 years ago

@edsko Also: assuming this does require a new GHC build, will make 2 in the old build be sufficient or does it need a full clean/rebuild?

edsko commented 10 years ago

@manny-fp Sorry for being unclear. You do need to rebuild -- it's your option (B) :) And yes, make 2 should suffice.

edsko commented 10 years ago

Done in https://github.com/fpco/ghc/commit/796f4f89aeaacc778c75f7f05ecf6e37279841ce .

borsboom commented 10 years ago

@edsko @snoyberg What's the best way to test whether these patches are applied (ideally through the IDE, although from the command-line would be OK too)? I had a mess around with the Makefiles a bit to get make binary-dist to work after cd ghc; make 2, so I want to make sure everything ended up in the right place.

Mikolaj commented 10 years ago

@manny-fp: Not sure which version of ide-backend you are using, but at some point I had these problems precisely due to no backport to 7.4:

https://github.com/fpco/ide-backend/issues/214#issuecomment-49861345

edsko commented 10 years ago

It's not so straightforward because all these patches addressed non-deterministic failures. I cannot give you a clearcut test I think.