fpco / ide-backend

ide-backend drives the GHC API to build, query, and run your code
120 stars 17 forks source link

Allow current working directory to be the data directory. #278

Closed urbanslug closed 9 years ago

urbanslug commented 9 years ago

We want to to allow for the configDir to be allowed to act as the data directory when the user choses this is through adding a field dataDirAsConfigDir :: Bool to SessionConfig.

snoyberg commented 9 years ago

@mgsloan since you're already working on this codebase, would you review this PR? @urbanslug is working on the updated yesod devel which will use ide-backend. For that use case, it makes more sense to grab the data files from the project's directory than copying to some other place.

mgsloan commented 9 years ago

Ideally, when using ide-backend locally, it would be possible to use their own directory for both source files and data files. I've looked into this a bit and opened an issue about this. Feel free to have a swing at that, but if it doesn't easily work out, I wouldn't prioritize it over the main yesod devel work.

Thanks for the attention to detail in your PR regarding commit messages and comments! I've got the following feedback:

So, to get this merge, I'd either like to see my comments above addressed or an implementation of #280