search

fpco / ide-backend

ide-backend drives the GHC API to build, query, and run your code
120 stars 17 forks source link

Fix build failures for GHC 7.4 in ide-backend-common #283

Closed hvr closed 9 years ago

hvr commented 9 years ago

GHC 7.2 would be fixable too with some effort, but I don't think it's worth the trouble w/ GHC 7.2 being a tech-preview release. GHC 7.0 is out of reach, as the code relies heavily on DeriveGenerics

hvr commented 9 years ago

PS: source-repo and bug-report urls are missing from the .cabal files; I had to lucky guess where the issue tracker was... :-)

snoyberg commented 9 years ago

Thank you for the PR, but I'm not sure if this is worth merging in. GHC 7.4 is probably not properly supported anyway due to changes in the semantics of the ghc library. Assigning to @mgsloan for review.

hvr commented 9 years ago

@snoyberg if you don't plan to support GHC 7.4, then please set base >= 4.6 (as well as the tighter lower bounds for containers and pretty-show as they're currently provably wrong) in future releases to signal this more explicitly

snoyberg commented 9 years ago

I would have, but I just copied the bounds from work someone else did.

mgsloan commented 9 years ago

Sorry for letting this languish. ide-backend-server does support 7.4.2, so it makes sense to be able to build with 7.4.2.

I've merged this, but I haven't tested that it builds with 7.4.2, as I'm assuming the build worked for @hvr.