search

fpco / inline-c

284 stars 51 forks source link

Skip generating foreign calls under ghcide, generate stubs instead #128

Closed nh2 closed 11 months ago

nh2 commented 2 years ago

See https://github.com/haskell/haskell-language-server/issues/365#issuecomment-976294466

The __GHCIDE__ environment variable is not currently set by haskell-language-server -- if this approach I'm implementing here (TH using this env var) is sanctioned by HLS developers, HLS should set this variable. Currently I set it myself in my shell.

junjihashimoto commented 11 months ago

I'd like to create a separate branch to deal with it.

nh2 commented 11 months ago

I'd like to create a separate branch to deal with it.

@junjihashimoto What does that mean?

junjihashimoto commented 11 months ago

It means that it just clones the patched one to own repository.

junjihashimoto commented 11 months ago

@nh2 I don't think it's an ideal solution, but it's better to merge, right?

nh2 commented 11 months ago

@nh2 I don't think it's an ideal solution, but it's better to merge, right?

Yes, probably. I just commented in https://github.com/haskell/haskell-language-server/issues/365#issuecomment-1740944383 because I think this change is still needed.

I think the only open question is how the env var should be called (https://github.com/haskell/haskell-language-server/issues/365#issuecomment-981627820) so it's probably cleanest to merge this PR here only once that's been decided and implemented in HLS.

junjihashimoto commented 11 months ago

@nh2 This PR is merged. inline-c-0.9.1.10 is available with this feature.

nh2 commented 11 months ago

@junjihashimoto Thanks!