search

fpco / inline-c

284 stars 50 forks source link

Add Semigroup instances for Context and Specifiers #66

Closed RyanGlScott closed 6 years ago

RyanGlScott commented 6 years ago

This is needed to fix the build on GHC 8.4.1, where Semigroup has become a superclass of Monoid.

This commit declares a dependency on semigroups, but inline-c was already depending on semigroups transitively through parsers.

RyanGlScott commented 6 years ago

Oops, this patch requires a more recent version of ansi-wl-pprint (which declares a Semigroup instance for Doc), but stack is bringing in an old version. Let's see if I can fix that...

edit: Done.

RyanGlScott commented 6 years ago

GHC 8.4.1 has been released. Can you please merge this and upload a new release to Hackage with this change?

peti commented 6 years ago

Ping?

bitonic commented 6 years ago

i believe #74 subsumes this. please reopen if that's not the case.