Closed chrisdone closed 9 years ago
I see no harm in boosting the base upper bound. bb5b2bf
I wrote up a README. I think it's rather longwinded and should probably be pared down, or part of it moved to a blog post or something. ee045f63
Nice work! This does a good job of explaining the commands and architecture.
Yeah, I think the Examples section probably belongs on a separate page about sandbox use; maybe a wiki page or a blog post. Pinging @snoyberg for third opinion.
No strong opinion; I don't have an objection to a long README. Blog posts bitrot, so I don't think that should be the canonical source of information.
On Tue, Apr 7, 2015 at 12:57 PM Chris Done notifications@github.com wrote:
Nice work! This does a good job of explaining the commands.
Yeah, I think the Examples section probably belongs on a separate page about sandbox use; maybe a wiki page or a blog post. Pinging @snoyberg https://github.com/snoyberg for third opinion.
— Reply to this email directly or view it on GitHub https://github.com/fpco/stackage-cli/issues/8#issuecomment-90493060.
If not a blog post then I think it should be changed to read more like formal docs than a blog post.
I propose: everything before Example
stays in the readme. Everything after Example
goes into a blog post. The readme has a link to the blog post for those who want to see the example. The readme's link to the blog post can be deleted or updated as things change.
Sounds good.
We'd like to have #14 done before release.
I've done as proposed and moved the example to the wiki.
Alright, I'll do a once over check here for all the features and then pass to Michael to review.
@snoyberg So I gave this a final sanity check and I'm happy with it. The global configuration I've only reviewed and tested, but the sandboxes I'm using on my own personal projects now. Want to give it a try yourself?
(Also, I've tested it with the nascent stackage-build
and it works unmodified as expected.)
OK, steps to do to finish this:
cabal install stackage
Let's hold off on updating instructions on stackage.org/install and yesodweb.com/page/quickstart until we get more user feedback on the tool.
Some items for clean up before open sourcing:
cabal haddock
yields something reasonably nice as an FP Complete product.README
explaining what the tool is for, the basic architecture and the few included commands.base
is too restrictive. Can it be lifted to <5?That should be it and then we can open source the project and upload to Hackage and include in Stackage.