search

fpco / streaming-commons

Common lower-level functions needed by various streaming data libraries
MIT License
36 stars 41 forks source link

don't reference deprecated functions #33

Closed ggreif closed 8 years ago

ggreif commented 8 years ago

Removes a bunch of GHC warnings related to NS.bindSocket and NS.sClose

ggreif commented 8 years ago

The build failures on older GHCs seem to come from a broken binary package on those. Not my fault.

snoyberg commented 8 years ago

Looks like the issue with binary is being tracked upstream at https://github.com/kolmodin/binary/issues/123.

ggreif commented 8 years ago

@snoyberg when restarting a recent green check on travis, will it fail the same way with binary?

snoyberg commented 8 years ago

Most likely, yes. I'm just hoping that binary will end up having a quick Hackage revision to fix the problem.

snoyberg commented 8 years ago

I've pushed commit 93fea18 to try and fix this, let's see what happens.

snoyberg commented 8 years ago

Can you try rebasing on master?

ggreif commented 8 years ago

@snoyberg stuff looks prettier now!

snoyberg commented 8 years ago

Do we need any kind of lower bound on network for when the new names were introduced? I'm not sure how old the identifiers are.

ggreif commented 8 years ago

v2.4.0.0 should be fine: https://github.com/haskell/network/commit/4db251a7d579b3efa606f69739e18cc6f9b64d02

snoyberg commented 8 years ago

Cool, can you add that to this PR?

ggreif commented 8 years ago

@snoyberg done :-)

snoyberg commented 8 years ago

Cool, thanks! I'll merge once Travis goes green.