fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 98 forks source link

WIP: Demonstrate basic ASG integration with lifecycle hooks #189

Closed psibi closed 5 years ago

ketzacoatl commented 5 years ago

As a first pass, getting an example working, this looks great!

Reviewing in detail, I would recommend the following updates:

It's not necessary now, but just as a heads up, I'll want to squash down the commits (can be more than 1 commit, but should be a clear logical flow without the sausage making)..

It would also be great to add to this PR, some example output or screenshots that confirm the lifecycle hooks are functional.

psibi commented 5 years ago

Some updates:

But there are still some points which needs to addressed from your above comments which I will work on.

psibi commented 5 years ago

Some updates from last changes:

ketzacoatl commented 5 years ago

This resolves https://github.com/fpco/terraform-aws-foundation/issues/188