fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
203 stars 99 forks source link

add resources for generic, load-based, dynamic autoscaling to the existing `asg` module #212

Open ketzacoatl opened 4 years ago

ketzacoatl commented 4 years ago

Our existing asg module is a LC/ASG pair. After this update, the asg module would also include a set of resources to scale up/down the ASG. These resources are optional, and will be parametized.

Requirements

Magicloud commented 4 years ago

Seems like I just need move the calling to autoscaling-policy-metric-alarm-pair in load-asg example to asg module.

Magicloud commented 4 years ago

My design is kind hard to implement. If I give asg module a switch to turn on/off the autoscaling, and use count trick in the autoscaling module, it won't work because module does not support count yet.

Maybe we should merge the autoscaling-policy-metric-alarm-pair module into asg module?

Magicloud commented 4 years ago

Thinking about it, it is reasonable to combine the two modules, since the policy is meaningless without a group. But for user wants different metric, the builtin policy would be a burden, not too much.