Bugfix and improvement.

Magicloud commented 5 years ago

ASG user_data cannot be empty string. So rework default value.
ASG does not take target group for ALB usage.

name: Pull request template about: Make a PR to terraform-aws-foundation

Please include the following in your PR:

Please also note that these are not hard requirements, but merely serve to define what maintainers are looking for in PR's. Including these will more likely lead to your PR being reviewed and accepted.

[ ] Update the changelog
[ ] Make sure that modules and files are documented. This can be done inside the module and files.
[ ] Make sure that new modules directories contain a basic README.md file.
[ ] Make sure that the module is added to tests/main.tf
[ ] Make sure that the linting passes on CI.
[ ] Make sure that there is an up to date example for your code:
- For new modules this would entail example code for how to use the module or some explanation in the module readme.
- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
[ ] Make sure that there is a manual CI trigger that can test the deployment.

Magicloud commented 5 years ago

@qrilka I knew you used web-alb module. So please give advise here.

qrilka commented 5 years ago

Nah, in the end it didn't work out because of requirement of preexisting ACM certificate. So in the end I stole some code from https://gitlab.fpcomplete.com/greatcall/consumer-env/tree/master/terraform/modules/env-wrapper I'll take a look into this tomorrow

ketzacoatl commented 5 years ago

When using ALB's elsewhere, I generally found it best to keep the ALB separate from the Target Groups. Target Groups are more closely associated with ASGs (1:1). It's also questionable to combine the listeners with ALB.

Magicloud commented 5 years ago

@ketzacoatl I have update the PR for some minor changes underneath. Please review.

ketzacoatl commented 4 years ago

@Magicloud can you confirm using this parameter, or using the ELB parameter, don't conflict with each other?

Magicloud commented 4 years ago

The PR seems overlap some new code in master. Closing.

fpco / terraform-aws-foundation

Bugfix and improvement. #237

name: Pull request template about: Make a PR to terraform-aws-foundation