fpco / terraform-aws-foundation

Establish a solid Foundation on AWS with these modules for Terraform
MIT License
204 stars 98 forks source link

iam-instance-profile modue: Expose IAM role id #254

Closed psibi closed 4 years ago

psibi commented 4 years ago

Please also note that these are not hard requirements, but merely serve to define what maintainers are looking for in PR's. Including these will more likely lead to your PR being reviewed and accepted.

mcgirr commented 4 years ago

@ketzacoatl I'm going to update the merge conflicts on this MR but I'd like to fast track getting this merged. I have a WIP change for the single-node-asg module that uses the iam-instance-profile module and I need the changes that this MR makes there.

Edit: Actually I just need iam_role_arn and that's already available. I'll still take a look at the merge conflict with CHANGELOG.md